feat: Added Utils class #169
Merged
+61
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atm1504
requested changes
Jun 10, 2019
| editor.putString(Constant.CITY, ""); | ||
| editor.putString(Constant.STATE, ""); | ||
| editor.putString(Constant.ACHIEVEMENTS, ""); | ||
| editor.apply(); | ||
| Toast.makeText(this, "Logged Out", Toast.LENGTH_LONG).show(); |
There was a problem hiding this comment.
@atm1504 i don't think it's a good idea, since we can reset values for other purposes also(excluding logout)
There was a problem hiding this comment.
The moment u call this, u r actually logging out first, then resetting the values. So, it would be a good habit to inform the user that he has been logged out.
There was a problem hiding this comment.
Before logout an alert dialog pops up.....After logout Toast is displayed...
| @@ -318,29 +319,10 @@ private void setHeaderData() { | |||
|
|
|||
| private void clearData() { | |||
| editor = preferences.edit(); | |||
| //method to reset shared preferences | |||
| Utils.resetSharedPreferences(preferences, editor); | |||
| if (preferences.getBoolean(Constant.LOGIN_STATUS, false)) { | |||
atm1504
approved these changes
Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #164
Changes: I have added a utility class
It has two methods:
one to close keyboard.
Second to reset Shared Preferences.